[CRIU] Fake mount points in dump

Stanislav Kinsburskiy skinsbursky at odin.com
Thu Jan 21 04:35:39 PST 2016



21.01.2016 13:28, Pavel Emelyanov пишет:
>>>>>> What was the reason to invent one more callback?
>>>>> One more additionally to which?
>>>> In addition to dump callback.
>>>> Why it was required to add "parse" callback and parse options there
>>>> instead of parsing them in "dump" callback?
>>> Because we parse /proc/mountinfo in advance and re-parsing it at
>>> dump time slows things down. It's better to get everything we need
>>> in one go.
>>>
>> Then, probably, "parse" callback is a wrong place to use for autofs checks.
> Good idea.
>
>> I can move it back to dump stage, or introduce one more "predump" callback, which
>> will be aimed to check, whether mount point can be migrated or not. It will be
>> called _only_ for "dump" (and maybe "check", if you would wish) stages.
>> And would be nice to make some decision regarding autofs series.
> I've sent my comments already, plz, fix them.

So, you want me to introduce some kind of superblock object?

> -- Pavel 



More information about the CRIU mailing list