[CRIU] Fake mount points in dump

Pavel Emelyanov xemul at parallels.com
Thu Jan 21 04:53:00 PST 2016


On 01/21/2016 03:35 PM, Stanislav Kinsburskiy wrote:
> 
> 
> 21.01.2016 13:28, Pavel Emelyanov пишет:
>>>>>>> What was the reason to invent one more callback?
>>>>>> One more additionally to which?
>>>>> In addition to dump callback.
>>>>> Why it was required to add "parse" callback and parse options there
>>>>> instead of parsing them in "dump" callback?
>>>> Because we parse /proc/mountinfo in advance and re-parsing it at
>>>> dump time slows things down. It's better to get everything we need
>>>> in one go.
>>>>
>>> Then, probably, "parse" callback is a wrong place to use for autofs checks.
>> Good idea.
>>
>>> I can move it back to dump stage, or introduce one more "predump" callback, which
>>> will be aimed to check, whether mount point can be migrated or not. It will be
>>> called _only_ for "dump" (and maybe "check", if you would wish) stages.
>>> And would be nice to make some decision regarding autofs series.
>> I've sent my comments already, plz, fix them.
> 
> So, you want me to introduce some kind of superblock object?

There were more than just this comment :) As far as this one is concerned
it would be enough just to introduce a single autofs_super_entry and put
them all into single image, one-by-one.

And add a note on a wiki (https://criu.org/What%27s_bad_with_V1_images) about 
this thing being not 100% perfect.

-- Pavel



More information about the CRIU mailing list