[CRIU] Fake mount points in dump

Pavel Emelyanov xemul at parallels.com
Thu Jan 21 04:28:24 PST 2016


>>>>> What was the reason to invent one more callback? 
>>>> One more additionally to which? 
>>>
>>> In addition to dump callback. 
>>> Why it was required to add "parse" callback and parse options there 
>>> instead of parsing them in "dump" callback? 
>>
>> Because we parse /proc/mountinfo in advance and re-parsing it at 
>> dump time slows things down. It's better to get everything we need 
>> in one go. 
>>
> 
> Then, probably, "parse" callback is a wrong place to use for autofs checks.

Good idea.

> I can move it back to dump stage, or introduce one more "predump" callback, which
> will be aimed to check, whether mount point can be migrated or not. It will be
> called _only_ for "dump" (and maybe "check", if you would wish) stages.
> And would be nice to make some decision regarding autofs series.

I've sent my comments already, plz, fix them.

> Please, note, that the feature is urgent and from my POW it would be nice to
> postpone any architectural changes, because right now I'm focused on NFS migration.

Urgency is not an excuse for ad-hoc solutions that will be impossible
or too hard to get rid of.

-- Pavel


More information about the CRIU mailing list