[CRIU] [PATCH 01/11] images: remap-file-path -- Reserve entries for NFS support
Pavel Emelyanov
xemul at virtuozzo.com
Thu Aug 4 07:27:05 PDT 2016
On 08/04/2016 04:58 PM, Cyrill Gorcunov wrote:
> On Thu, Aug 04, 2016 at 04:59:05PM +0300, Pavel Emelyanov wrote:
>>> @@ -1,9 +1,13 @@
>>> syntax = "proto2";
>>>
>>> enum remap_type {
>>> - LINKED = 0;
>>> - GHOST = 1;
>>> - PROCFS = 2;
>>> + LINKED = 0;
>>> + GHOST = 1;
>>> + PROCFS = 2;
>>> +
>>> + /* Reserve for NFS support */
>>> + SPFS = 3;
>>> + SPFS_LINKED = 4;
>>
>> Please, comment those out as it's done in mnt.proto.
>
> I believe we should not. Moreover we better uncomment
> them in mnt.proto. Both symbolic names and values
> _must_not_ intersect with anything else in source code.
Symbolic names do not matter, as we've seen this some time ago ;)
Only the numbers are of interest.
-- Pavel
More information about the CRIU
mailing list