[CRIU] [PATCH 01/11] images: remap-file-path -- Reserve entries for NFS support

Cyrill Gorcunov gorcunov at gmail.com
Thu Aug 4 06:58:50 PDT 2016


On Thu, Aug 04, 2016 at 04:59:05PM +0300, Pavel Emelyanov wrote:
> > @@ -1,9 +1,13 @@
> >  syntax = "proto2";
> >  
> >  enum remap_type {
> > -  LINKED		= 0;
> > -  GHOST 		= 1;
> > -  PROCFS		= 2;
> > +	LINKED		= 0;
> > +	GHOST		= 1;
> > +	PROCFS		= 2;
> > +
> > +	/* Reserve for NFS support */
> > +	SPFS		= 3;
> > +	SPFS_LINKED	= 4;
> 
> Please, comment those out as it's done in mnt.proto.

I believe we should not. Moreover we better uncomment
them in mnt.proto. Both symbolic names and values
_must_not_ intersect with anything else in source code.


More information about the CRIU mailing list