[CRIU] [PATCH 01/11] images: remap-file-path -- Reserve entries for NFS support

Cyrill Gorcunov gorcunov at gmail.com
Thu Aug 4 07:43:17 PDT 2016


On Thu, Aug 04, 2016 at 05:27:05PM +0300, Pavel Emelyanov wrote:
> >> Please, comment those out as it's done in mnt.proto.
> > 
> > I believe we should not. Moreover we better uncomment
> > them in mnt.proto. Both symbolic names and values
> > _must_not_ intersect with anything else in source code.
> 
> Symbolic names do not matter, as we've seen this some time ago ;)
> Only the numbers are of interest.

No, no. I think I did wrong explanation. Look, when we compile CRIU,
even the _names_ of these variable must not clash with anything else.
IOW, it's name reserving for very own purpose. Of course we can
rename them at any moment without breaking binary level, but
having them reserved from the beginning will save us one day,
believe me.


More information about the CRIU mailing list