[CRIU] [PATCH] criu: x86 -- Drop @ds test from compat mode

Cyrill Gorcunov gorcunov at gmail.com
Thu Apr 14 04:36:06 PDT 2016


On Thu, Apr 14, 2016 at 02:28:39PM +0300, Dmitry Safonov wrote:
> 
> I will resend patch '[PATCHv2 13/17] x86/crtools: rework
> arch_task_compatible'
> from my series, so it will work.
> I think, the best way in this situation is to check if
> CS register is one of __USER_CS or __USER32_CS
> and if not so - put a warning (but not interrupt dump)
> as a task may have some selector, but not corresponding
> descriptor in table. But there _should_ be warning
> as descriptors table may have needed LDT for
> CS selector  - and ideally, we should dump LDT too,
> but yet let this be a warning.

Since we don't keep ldt we should not proceed dumping
because on restore the program will be screwed, so
simply interrupt the dumping. The rest looks ok to me.

> Does this look good for you, guys?
> I will resend that patch shortly, if so.


More information about the CRIU mailing list