[CRIU] [PATCH] criu: x86 -- Drop @ds test from compat mode

[Dmitry Safonov]

On 04/14/2016 02:36 PM, Cyrill Gorcunov wrote:
> On Thu, Apr 14, 2016 at 02:28:39PM +0300, Dmitry Safonov wrote:
>> I will resend patch '[PATCHv2 13/17] x86/crtools: rework
>> arch_task_compatible'
>> from my series, so it will work.
>> I think, the best way in this situation is to check if
>> CS register is one of __USER_CS or __USER32_CS
>> and if not so - put a warning (but not interrupt dump)
>> as a task may have some selector, but not corresponding
>> descriptor in table. But there _should_ be warning
>> as descriptors table may have needed LDT for
>> CS selector  - and ideally, we should dump LDT too,
>> but yet let this be a warning.
> Since we don't keep ldt we should not proceed dumping
> because on restore the program will be screwed, so
> simply interrupt the dumping. The rest looks ok to me.
So, that's how the patch from my series does at
this moment. But, I think the issue, Federico had
was cs != 0x33 and removing this check worked
for him. May be by the reason, cs was 0x23
(__USER32_CS) - if so, it will work with my patch.
>
>> Does this look good for you, guys?
>> I will resend that patch shortly, if so.

-- 
Regards,
Dmitry Safonov