[CRIU] [PATCH] criu: x86 -- Drop @ds test from compat mode

Dmitry Safonov dsafonov at virtuozzo.com
Thu Apr 14 04:28:39 PDT 2016


On 04/14/2016 01:49 PM, Pavel Emelyanov wrote:
> On 04/14/2016 01:40 PM, Cyrill Gorcunov wrote:
>> You know, Dima did something close to this in his x86-32 series and
>> it will conflict. What's the plans on x86-32?
> I'll review it today, but your acks/nacks would be helpful.
Hello, thanks.
>
>> Maybe worth to merge his series instead?
> Does it fix the issue Federico has met?

I will resend patch '[PATCHv2 13/17] x86/crtools: rework 
arch_task_compatible'
from my series, so it will work.
I think, the best way in this situation is to check if
CS register is one of __USER_CS or __USER32_CS
and if not so - put a warning (but not interrupt dump)
as a task may have some selector, but not corresponding
descriptor in table. But there _should_ be warning
as descriptors table may have needed LDT for
CS selector  - and ideally, we should dump LDT too,
but yet let this be a warning.
Does this look good for you, guys?
I will resend that patch shortly, if so.

-- 
Regards,
Dmitry Safonov



More information about the CRIU mailing list