[CRIU] Re: [PATCH 08/10] syscalls: Complete redesign v4

[Cyrill Gorcunov]

On Mon, Apr 16, 2012 at 03:01:00PM +0400, Cyrill Gorcunov wrote:
> On Mon, Apr 16, 2012 at 02:57:34PM +0400, Pavel Emelyanov wrote:
> > > 
> > > To fix all this -- now syscalls declarations are generated from
> > > syscall.def file and function arguments are passed in conform
> > > with x86-64 ABI.
> > > 
> > > This shrinks amount of source code needed to declare syscalls
> > > and opens a way to use optimization.
> > > 
> > > Signed-off-by: Cyrill Gorcunov <gorcunov at openvz.org>
> > 
> > I have 2 concerns about this patch.
> > 
> > 1. It mixes cleanups with payload (e.g. fixup args for syscalls or
> >    move structures/constants to header). Plz, split.
> 
> OK
> 
> > 2. The syscall generator is written on perl. What perl is here for?
> 
> Because perl is simplier for me to parse template. I though about
> using awk here, but I don't have much experience with awk.
> If someone help me -- I would really appreciate.

The template itself is extremelly simple

+# name			code		name			arguments
+# -----------------------------------------------------------------------
+#
+__NR_read		0		sys_read		(int fd, void *buf, unsigned long count)


	Cyrill