[CRIU] Re: [PATCH 08/10] syscalls: Complete redesign v4
Cyrill Gorcunov
gorcunov at openvz.org
Mon Apr 16 07:01:00 EDT 2012
On Mon, Apr 16, 2012 at 02:57:34PM +0400, Pavel Emelyanov wrote:
> >
> > To fix all this -- now syscalls declarations are generated from
> > syscall.def file and function arguments are passed in conform
> > with x86-64 ABI.
> >
> > This shrinks amount of source code needed to declare syscalls
> > and opens a way to use optimization.
> >
> > Signed-off-by: Cyrill Gorcunov <gorcunov at openvz.org>
>
> I have 2 concerns about this patch.
>
> 1. It mixes cleanups with payload (e.g. fixup args for syscalls or
> move structures/constants to header). Plz, split.
OK
> 2. The syscall generator is written on perl. What perl is here for?
Because perl is simplier for me to parse template. I though about
using awk here, but I don't have much experience with awk.
If someone help me -- I would really appreciate.
Cyrill
More information about the CRIU
mailing list