[CRIU] Re: [PATCH 08/10] syscalls: Complete redesign v4

[Pavel Emelyanov]

On 04/16/2012 03:01 PM, Cyrill Gorcunov wrote:
> On Mon, Apr 16, 2012 at 02:57:34PM +0400, Pavel Emelyanov wrote:
>>>
>>> To fix all this -- now syscalls declarations are generated from
>>> syscall.def file and function arguments are passed in conform
>>> with x86-64 ABI.
>>>
>>> This shrinks amount of source code needed to declare syscalls
>>> and opens a way to use optimization.
>>>
>>> Signed-off-by: Cyrill Gorcunov <gorcunov at openvz.org>
>>
>> I have 2 concerns about this patch.
>>
>> 1. It mixes cleanups with payload (e.g. fixup args for syscalls or
>>    move structures/constants to header). Plz, split.
> 
> OK
> 
>> 2. The syscall generator is written on perl. What perl is here for?
> 
> Because perl is simplier for me to parse template. I though about
> using awk here, but I don't have much experience with awk.
> If someone help me -- I would really appreciate.

You need to convert strings like 

   foo bar foobar

into smth like

   abc def {
   	foo
   	smth else
   	bar
   } foobar

This is done like this

   echo $str | awk '{print abc def { $1 smth else $2 } $4}'

Very simple :)

> 	Cyrill
> _______________________________________________
> CRIU mailing list
> CRIU at openvz.org
> https://openvz.org/mailman/listinfo/criu
>