[Devel] [PATCH vz9] ploop: fsync after all pios are sent

Andrey Zhadchenko andrey.zhadchenko at virtuozzo.com
Wed Oct 9 15:52:44 MSK 2024



On 10/9/24 14:45, Alexander Atanasov wrote:
> On 9.10.24 15:43, Andrey Zhadchenko wrote:
> 
> 
>>
>> On 10/8/24 13:46, Alexander Atanasov wrote:
>>> On 8.10.24 14:35, Andrey Zhadchenko wrote:
>>>>
> 
>>
>> Code from ploop_dispatch_pio():
>>
>>      if (pio->queue_list_id == PLOOP_LIST_FLUSH)
>>          *is_flush = true;
>>      else
>>          *is_data = true;
>>
>> So I think these flags in a context of ploop_dispatch_pios() are 
>> mutually exclusive.
> 
> 
> void ploop_dispatch_pios(struct ploop *ploop, struct pio *pio,
>               struct list_head *pio_list)
> {
> ....
>      if (pio_list) {
>          while ((pio = ploop_pio_list_pop(pio_list)) != NULL)
>              ploop_dispatch_pio(ploop, pio, &is_data, &is_flush);
>      }
> ...
> }
> 
> in some cases lists of pios are submitted and they are not.

Yeah, you are right. I completely missed that

> 
> 
> 
> 


More information about the Devel mailing list