[Devel] [PATCH vz9] ploop: fsync after all pios are sent

Alexey Kuznetsov alexey.n.kuznetsov at gmail.com
Tue Oct 8 18:42:46 MSK 2024


Hello!

       if (is_data)
                queue_work(ploop->wq, &ploop->worker);
-       if (is_flush)
+       else if (is_flush)
                queue_work(ploop->wq, &ploop->fsync_worker);

IMHO this looks scary. bio with FLUSH must execute flush first,
and only after completion of flush data op in this bio is executed.
This used to be an absolute requirement since 2010. Lines
above look like they are desynchronized whch will defintely
lead to corruptions.

F.e. fs commit is submitte


More information about the Devel mailing list