[Devel] [PATCH RHEL8 COMMIT] ve: fix copy_vdso error handling

Konstantin Khorenko khorenko at virtuozzo.com
Fri Jul 16 19:45:32 MSK 2021


The commit is pushed to "branch-rh8-4.18.0-305.3.1.vz8.7.x-ovz" and will appear at https://src.openvz.org/scm/ovz/vzkernel.git
after rh8-4.18.0-305.3.1.el8
------>
commit 06992036918bc34a448c823fe8dac5341d290f5c
Author: Pavel Tikhomirov <ptikhomirov at virtuozzo.com>
Date:   Fri Jul 16 19:45:32 2021 +0300

    ve: fix copy_vdso error handling
    
    Else we would return null pointer (e.g. to cgroup_init_subsys) and
    IS_ERR would say that it's not an error and the caller code
    would badly consider ve_start being successful while it's not.
    
    Fixes: f70968ae7b3e ("ve, x86_64: add per-ve vdso mapping.")
    
    https://jira.sw.ru/browse/PSBM-131158
    
    Signed-off-by: Pavel Tikhomirov <ptikhomirov at virtuozzo.com>
---
 kernel/ve/ve.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/kernel/ve/ve.c b/kernel/ve/ve.c
index 81db6b32ab29..fee86917d624 100644
--- a/kernel/ve/ve.c
+++ b/kernel/ve/ve.c
@@ -903,6 +903,7 @@ static struct cgroup_subsys_state *ve_create(struct cgroup_subsys_state *parent_
 	if (err)
 		goto err_log;
 
+	err = -ENOMEM;
 	if (copy_vdso(&ve->vdso_64, &vdso_image_64))
 		goto err_vdso;
 


More information about the Devel mailing list