[Devel] [PATCH RH8] ve: fix copy_vdso error handling

Pavel Tikhomirov ptikhomirov at virtuozzo.com
Fri Jul 16 18:20:44 MSK 2021


Else we would return null pointer (e.g. to cgroup_init_subsys) and
IS_ERR would say that it's not an error and the caller code
would badly consider ve_start being successful while it's not.

https://jira.sw.ru/browse/PSBM-131158

Signed-off-by: Pavel Tikhomirov <ptikhomirov at virtuozzo.com>
---
 kernel/ve/ve.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/kernel/ve/ve.c b/kernel/ve/ve.c
index 81db6b32ab29..fee86917d624 100644
--- a/kernel/ve/ve.c
+++ b/kernel/ve/ve.c
@@ -903,6 +903,7 @@ static struct cgroup_subsys_state *ve_create(struct cgroup_subsys_state *parent_
 	if (err)
 		goto err_log;
 
+	err = -ENOMEM;
 	if (copy_vdso(&ve->vdso_64, &vdso_image_64))
 		goto err_vdso;
 
-- 
2.31.1



More information about the Devel mailing list