[Devel] [PATCH vz9] cgroup: close a race window on cgrp removal
Kirill Tkhai
ktkhai at virtuozzo.com
Thu Dec 16 13:29:03 MSK 2021
On 16.12.2021 13:22, Nikita Yushchenko wrote:
>>> + if (WARN_ON(!cgroup_tryget(cgrp)))
>>> + continue;
>>> +
>>
>> Wouldn't it be better to use cancel_work_sync() in ve_rm_from_release_list() instead?
>
> Since work is shared between cgrroups, this can cause work for unrelated cgrp cancelled.
>
> Upstream has a change that makes the work item per-crgp, and porting that looks a good idea, but that's somewhat more complex.
Ok, this is the reason.
More information about the Devel
mailing list