[Devel] [PATCH vz9] cgroup: close a race window on cgrp removal

Nikita Yushchenko nikita.yushchenko at virtuozzo.com
Thu Dec 16 13:22:47 MSK 2021


>> +		if (WARN_ON(!cgroup_tryget(cgrp)))
>> +			continue;
>> +
> 
> Wouldn't it be better to use cancel_work_sync() in ve_rm_from_release_list() instead?

Since work is shared between cgrroups, this can cause work for unrelated cgrp cancelled.

Upstream has a change that makes the work item per-crgp, and porting that looks a good idea, but that's 
somewhat more complex.




More information about the Devel mailing list