[Devel] [Q] migrating inotify assigned on ploop device

[Pavel Emelyanov]

On 01/12/2016 12:10 PM, Nikita Spiridonov wrote:
> On Tue, 2016-01-12 at 13:12 +0300, Pavel Emelyanov wrote:
>> On 01/12/2016 01:08 PM, Cyrill Gorcunov wrote:
>>> On Tue, Jan 12, 2016 at 12:56:16PM +0400, Nikita Spiridonov wrote:
>>> ...
>>>>
>>>> Which images concretely we have to update?
>>>
>>> All images where /dev/ploopXXX may be present. In particular
>>> reg-files, inotify.
>>>
>>>> And do we really need CRIT utility or protobuf API can be used to fix
>>>> images?
>>>
>>> CRIT I believe is more convenient. Pavel mentioned "recode" feature he
>>> has in mind for such actions.
>>>
>>> Pavel, could you please join the conversation?
>>
>> Easily.
>>
>> One cannot just use protobuf API, as criu images are slightly more
>> that protobuf. What I propose is the recode action for crit, that
>> would open an image, decode it, apply changes specified in command
>> line (exact syntax is TBD) and write them out modified.
> 
> Isn't it a considerable performance hit to recode all criu images on
> restore?

Not all, only those needed to.

>>
>> On restore we need to patch criu to spawn crit with recode action and
>> necessary recode rules. CRIT then would read data from images and write
>> them back to criu via pipe.
>>
>> -- Pavel
>>
> 
> 
> .
>