[Devel] [PATCH rh7] ve: introduce ve.veid for setting id from userspace

Cyrill Gorcunov gorcunov at virtuozzo.com
Sat Jun 20 13:27:08 PDT 2015


On Sat, Jun 20, 2015 at 10:41:03PM +0300, Vladimir Davydov wrote:
> On Sat, Jun 20, 2015 at 08:18:42PM +0300, Cyrill Gorcunov wrote:
> > On Sat, Jun 20, 2015 at 07:27:30PM +0300, Vladimir Davydov wrote:
> > ...
> > > +static int ve_id_write(struct cgroup *cg, struct cftype *cft, u64 value)
> > > +{
> > > +	struct ve_struct *ve = cgroup_ve(cg);
> > > +	int veid;
> > > +	int err = 0;
> > > +
> > > +	if (value <= 0 || value > INT_MAX)
> > > +		return -EINVAL;
> > 
> > A small nit -- @value is unsigned no need for <= test.
> > Other than that, looks great, thank you!
> 
> True, but it's purely a matter of personal preference, so let's leave it
> as is.

Sure thing!



More information about the Devel mailing list