[Devel] [PATCH rh7] ve: introduce ve.veid for setting id from userspace

[Vladimir Davydov]

On Sat, Jun 20, 2015 at 08:18:42PM +0300, Cyrill Gorcunov wrote:
> On Sat, Jun 20, 2015 at 07:27:30PM +0300, Vladimir Davydov wrote:
> ...
> > +static int ve_id_write(struct cgroup *cg, struct cftype *cft, u64 value)
> > +{
> > +	struct ve_struct *ve = cgroup_ve(cg);
> > +	int veid;
> > +	int err = 0;
> > +
> > +	if (value <= 0 || value > INT_MAX)
> > +		return -EINVAL;
> 
> A small nit -- @value is unsigned no need for <= test.
> Other than that, looks great, thank you!

True, but it's purely a matter of personal preference, so let's leave it
as is.

> 
> Acked-by: Cyrill Gorcunov <gorcunov at openvz.org>

Thanks.