[Devel] Re: [PATCH 1/2] ppc vdso: make sure rc is defined

[Serge E. Hallyn]

Quoting Nathan Lynch (ntl at pobox.com):
> "Serge E. Hallyn" <serue at us.ibm.com> writes:
> > Signed-off-by: Serge Hallyn <serue at us.ibm.com>
> > ---
> >  arch/powerpc/kernel/vdso.c |    4 +++-
> >  1 files changed, 3 insertions(+), 1 deletions(-)
> >
> > diff --git a/arch/powerpc/kernel/vdso.c b/arch/powerpc/kernel/vdso.c
> > index 48beff6..679b394 100644
> > --- a/arch/powerpc/kernel/vdso.c
> > +++ b/arch/powerpc/kernel/vdso.c
> > @@ -240,8 +240,10 @@ int arch_setup_additional_pages(struct linux_binprm *bprm,
> >  	}
> >  
> >  	/* for restart(2), double check that we got we asked for */
> > -	if (start && vdso_base != start)
> > +	if (start && vdso_base != start) {
> > +		rc = -EBUSY;
> >  		goto fail_mmapsem;
> > +	}
> >  
> >  	/*
> >  	 * our vma flags don't have VM_WRITE so by default, the process isn't
> 
> Is this why you sent this patch?
> 
> cc1: warnings being treated as errors
> arch/powerpc/kernel/vdso.c: In function arch_setup_additional_pages:
> arch/powerpc/kernel/vdso.c:194: error: rc may be used uninitialized in this function

Yup.

> If so, looks fine to me.

-serge
_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers