[Devel] Re: commit 7534432dcc3c654a8671b6b0cdffd1dbdbc73074

[Paul Menage]

On Thu, Jan 22, 2009 at 5:26 PM, Matt Helsley <matthltc at us.ibm.com> wrote:
>
>        I see what you mean. I am still mystified how rcu_read_lock() around
> the cgroup iterator in cgroupstats_build() hid/prevented the problem
> though :/.

I think the problem was in git bisect - the problematic commit was a
couple later than the one Serge pointed at.

>
>        Incrementing the root_count early dissociates root_count and the
> addition to root list, doesn't it? How about only decrementing the count
> if we're on the list as in the patch below?

That's basically the patch that I already sent out. That check was
there originally, but removed in
e5f6a8609bab0c2d7543ab1505105e011832afd7 as a "redundant check".

Paul
_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers