[Devel] Re: ptem01 LTP failure in ttydev-0909

[Subrata Modak]

Hi Sukadev,

On Thu, 2008-09-18 at 21:14 -0700, sukadev at linux.vnet.ibm.com wrote:
> Alan Cox [alan at lxorguk.ukuu.org.uk] wrote:
> | > The test changes the window size using the slave-fd and expects that
> | > it won't affect the window-size on master-fd. With this change, we
> | > return the slave's window size and test fails.
> | 
> | I've no idea why anyone would have thought the existing behaviour was
> | correct. The pty/tty pair code tries to share the size and other
> | information at all times and the old test was I think verifying a bug
> | existed.
> | 
> | Unless anyone can cite anything to show otherwise anyway ?
> 
> Subrata 
> 
> We are referring to the last window size check in test2() of
> testcases/kernel/pty/ptem01.c. This check will cause the test
> to fail when some of the planned ttydev changes are merged.
> 
> Would you happen to know if the check is really required or if
> it should be dropped ?

 I would want the test to remain there, but introduce some checkings
before running the test. As test2() is valid under present
circumstances, we should retain it as people will keep using LTP on
lower kernels.

Having said that, i would like to come with a solution where test2() of
testcases/kernel/pty/ptem01.c is not run after the planned ttydev
changes are merged. Something compile/run time checking to either not to
build that part of code and run it. Can we do something like that by
checking some glibc/kernel exported definitions ?

Regards--
Subrata

> 
> Suka

_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers