[Devel] [PATCH] sysctl: check for bogus modes

Alexey Dobriyan adobriyan at parallels.com
Thu May 29 07:15:53 PDT 2008


Catch, e. g., 644/0644 typo.

Signed-off-by: Alexey Dobriyan <adobriyan at parallels.com>
---

 kernel/sysctl_check.c |    2 ++
 1 file changed, 2 insertions(+)

--- a/kernel/sysctl_check.c
+++ b/kernel/sysctl_check.c
@@ -1532,6 +1532,8 @@ int sysctl_check_table(struct nsproxy *namespaces, struct ctl_table *table)
 			sysctl_check_leaf(namespaces, table, &fail);
 		}
 		sysctl_check_bin_path(table, &fail);
+		if (table->mode > 0777)
+			set_fail(&fail, table, "bogus .mode");
 		if (fail) {
 			set_fail(&fail, table, NULL);
 			error = -EINVAL;




More information about the Devel mailing list