[Devel] Re: [PATCH 6/13] BC: kmemsize accounting (core)

[Pavel Machek]

Hi!

> --- /dev/null	2006-07-18 14:52:43.075228448 +0400
> +++ ./include/bc/kmem.h	2006-11-03 15:48:26.000000000 +0300
> @@ -0,0 +1,48 @@
> +/*
> + * include/bc/kmem.h
> + *
> + * Copyright (C) 2006 OpenVZ SWsoft Inc
> + *
> + */

GPL would be nice, as would be email address of someone who worked on
this file.


> --- /dev/null	2006-07-18 14:52:43.075228448 +0400
> +++ ./kernel/bc/kmem.c	2006-11-03 15:48:26.000000000 +0300
> @@ -0,0 +1,112 @@
> +/*
> + * kernel/bc/kmem.c
> + *
> + * Copyright (C) 2006 OpenVZ SWsoft Inc
> + *
> + */

Same here.

> +void bc_slab_uncharge(kmem_cache_t *cachep, void *objp)
> +{
> +	unsigned int size;
> +	struct beancounter *bc, **slab_bcp;
> +
> +	slab_bcp = kmem_cache_bcp(cachep, objp);
> +	if (*slab_bcp == NULL)
> +		return;
> +
> +	bc = *slab_bcp;

You can do this before if() and spare a dereference.

						Pavel
-- 
Thanks for all the (sleeping) penguins.