[Devel] Re: [PATCH 6/13] BC: kmemsize accounting (core)

[Pekka Enberg]

On 11/9/06, Kirill Korotaev <dev at sw.ru> wrote:
> +#ifdef CONFIG_BEANCOUNTERS
> +#define BC_EXTRASIZE   sizeof(struct beancounter *)

Would much prefer you put all beancounter stuff into one #ifdef block
to avoid clutter.

> @@ -2579,14 +2635,14 @@ static struct slab *alloc_slabmgmt(struc
>         slabp->colouroff = colour_off;
>         slabp->s_mem = objp + colour_off;
>         slabp->nodeid = nodeid;
> +#ifdef CONFIG_BEANCOUNTERS
> +       if (cachep->flags & SLAB_BC)
> +               memset(slab_bc_ptrs(cachep, slabp), 0,
> +                               cachep->num * BC_EXTRASIZE);
> +#endif

No #ifdef within functions, please, but instead, make it an static
inline function.