[Debian] Re: Bug#504449: vzctl: Please apply Ubuntu changes

[Thorsten Schifferdecker]

Hi Ola,
 hi Nathan,

Am Di, 4.11.2008, 07:43, schrieb Ola Lundqvist:
> Hi Nathan
>
> Nice to hear from you. Yes this looks like a good patch.
> Some comments/questions below.
>
> On Mon, Nov 03, 2008 at 05:29:18PM -0600, Nathan Handler wrote:
> ...
>> In Ubuntu, we've applied the attached patch to achieve the following:
>>
>>  * etc/bash_completion.d/vzctl.sh.in:
>>     Use "/bin/ls" instead of "ls", so an existing alias for "ls"
>>     does not get used.
is fixed in upstream:
http://git.openvz.org/?p=vzctl;a=commit;h=92a5d6f71f41001ef1cc85a8f59b8d0a046a2297

>
> This sounds like a good patch. However I find it unlikely that
> root have any aliases. But it could of course be so. How critical
> did you find this one?
>
>>  * src/lib/ub.c: Fix typo: s/successefully/successfully/
>
> Ok good. I assume that this is not a critical thing.
is fixed in upstream:
http://git.openvz.org/?p=vzctl;a=commit;h=7a40b761f1ab080a2868ba77b5b421abcd49ab65

>>  * src/lib/config.c, src/lib/util.c: Explicitly include limits.h
>
> What is the reason for this? I assume that it helps you to compile
> on some platform but I want to check first.
>
>> We thought you might be interested in doing the same.
>
> Yes very interesting. However I think you are aware that we are
> close to release which makes me reluctant to do any changes right
> now. They will be applied after the release of lenny though.
>
> One more question. Have you submitted this upstream, or do you
> want me to do that?

see post below.

Regards,
 Thorsten Schifferdecker