[Debian] Re: Bug#472901: vzctl: bashism in /bin/sh script

[Ola Lundqvist]

Hi Raphael

Thanks for the report. I'll make it use bash directly instead until upstream
have changed this.

Best regards,

// Ola

On Wed, Mar 26, 2008 at 08:31:36PM -0600, Raphael Geissert wrote:
> Package: vzctl
> Severity: normal
> Version: 3.0.22-5
> User: debian-release at lists.debian.org
> Usertags: goal-dash
> 
> Hello maintainer,
> 
> While performing an archive wide checkbashisms (from the 'devscripts' package) 
> check I've found your package containing several /bin/sh scripts making 
> use of a bashism.
> 
> checkbashisms' output:
> > possible bashism in ./usr/sbin/vzpid line 33 (local foo=bar):
> >         local pid="$1"
> > possible bashism in ./usr/sbin/vzmigrate line 127 (echo -e):
> >                 echo -e "Error: " $@ >&2
> > possible bashism in ./usr/sbin/vzmigrate line 130 (echo -e):
> >                 echo -e $@
> > possible bashism in ./usr/sbin/vzmigrate line 133 (echo -e):
> >                 echo -e "   " $@
> > possible bashism in ./usr/sbin/vznetcfg line 29 (local foo=bar):
> >         local dev="$1"
> 
> Not using bash (or a Debian Policy conformant shell interpreter which doesn't 
> provide such an extra feature) as /bin/sh is likely to lead to errors or 
> unexpected behaviours.
> Please be aware that although bash is currently the default /bin/sh there's a 
> release goal for Lenny to make dash the default /bin/sh[1].
> 
> If you want more information about dash as /bin/sh, you can read:
> http://lists.debian.org/debian-release/2008/01/msg00189.html
> 
> For more information please refer to the Debian Policy section 10.4 supporting 
> this argument at:
> http://www.debian.org/doc/debian-policy/ch-files.html#s-scripts
> 
> Hints about how to fix bashisms:
> Sometimes these bugs are already fixed in Ubuntu, look at the PTS.
> If not already fixed you can read:
> https://wiki.ubuntu.com/DashAsBinSh
> 
> [1]http://release.debian.org/lenny/goals.txt
> 
> Thank you,
> -- 
> Atomo64 - Raphael
> 
> Please avoid sending me Word, PowerPoint or Excel attachments.
> See http://www.gnu.org/philosophy/no-word-attachments.html
> 
> 
> 

-- 
 --------------------- Ola Lundqvist ---------------------------
/  opal at debian.org                     Annebergsslingan 37      \
|  ola at opalsys.net                     654 65 KARLSTAD          |
|  http://opalsys.net/                 +46 (0)70-332 1551       |
\  gpg/f.p.: 7090 A92B 18FE 7994 0C36  4FE4 18A1 B1CF 0FE5 3DD9 /
 ---------------------------------------------------------------