[Debian] Re: Bug#470962: Incompatible with post-DSA-1428 kernel source

[Ola Lundqvist]

Hi Marcin

Now I understand what the problem is. I was not aware of that max fuzz problem.

I'll correct this.

Best regards,

// Ola

On Wed, Mar 19, 2008 at 11:03:12PM +0000, Marcin Owsiany wrote:
> On Sun, Mar 16, 2008 at 10:33:25PM +0100, Ola Lundqvist wrote:
> > I have verified it on target as well. As you do not tell what the incompatibility
> > is I would like you to describe the problem. Until you have specified it
> > more I'm lowering the serverity of this bug.
> 
> I've investigated this a bit, and the reason it fails for me, but not
> for you, is most probably you are using the default patch's maximum fuzz
> level of 2, while I am using a manually specified max fuzz level of 1.
> 
> Actually the fuzz level is not specified by me directly, but it is what
> patch.apply script from the linux-2.6 source package uses.
> 
> The problem looks like this:
> | patching file fs/sysfs/sysfs.h
> | Hunk #2 FAILED at 30.
> | 1 out of 2 hunks FAILED -- saving rejects to file fs/sysfs/sysfs.h.rej
> 
> and is about the following hunk:
> 
> | @@ -21,7 +30,6 @@ extern void sysfs_drop_dentry(struct sys
> |  extern int sysfs_setattr(struct dentry *dentry, struct iattr *iattr);
> | 
> |  extern struct rw_semaphore sysfs_rename_sem;
> | -extern struct super_block * sysfs_sb;
> |  extern const struct file_operations sysfs_dir_operations;
> |  extern const struct file_operations sysfs_file_operations;
> |  extern const struct file_operations bin_fops;
> 
> the DSA I mentioned in my original report added another extern variable
> declaration just before sysfs_rename_sem. That is why it applies with fuzz=2,
> but not with fuzz=1.
> 
> -- 
> Marcin Owsiany <porridge at debian.org>             http://marcin.owsiany.pl/
> GnuPG: 1024D/60F41216  FE67 DA2D 0ACA FC5E 3F75  D6F6 3A0D 8AA0 60F4 1216
> 
> 
> 

-- 
 --------------------- Ola Lundqvist ---------------------------
/  opal at debian.org                     Annebergsslingan 37      \
|  ola at opalsys.net                     654 65 KARLSTAD          |
|  http://opalsys.net/                 +46 (0)70-332 1551       |
\  gpg/f.p.: 7090 A92B 18FE 7994 0C36  4FE4 18A1 B1CF 0FE5 3DD9 /
 ---------------------------------------------------------------