[CRIU] [PATCH 9/9] Makefiles: protect from % rules, don't rebuild

Kir Kolyshkin kir at openvz.org
Mon Feb 27 22:15:30 PST 2017


On 02/27/2017 01:34 AM, Dmitry Safonov wrote:
> 2017-02-23 2:15 GMT+03:00 Kir Kolyshkin <kir at openvz.org>:
>> GNU make tries to rebuild any makefiles it uses. While in general it's
>> a good idea (and it is used e.g. in autoconf-based builds), in our case
>> it is not necessary, as all the makefiles are static.
>>
>> More to say, as we have a few "match anything" rules for subdirectories,
>> Makefiles in these subdirs are also matching these rules, which leads to
>> excessive (re)building while a particular makefile is needed.
>>
>> Protect such Makefiles with explicit (or pattern) rules, so make knows
>> it should do nothing to rebuild those.
>>
>> Signed-off-by: Kir Kolyshkin <kir at openvz.org>
> I guess, it should fix also #285, does it?
> If so, maybe it makes sense for Andrey to apply it with 'fixes' tag.
>
> Reviewed-by: Dmitry Safonov <dsafonov at virtuozzo.com>
>
No, the issue #285 was fixed some time ago in criu-dev. As for master, I 
will recheck.

This one is not related, although I made another patch to fix make 
uninstall in criu-dev
(already committed):

https://github.com/xemul/criu/commit/9af7a3a2ba3130118f4b22cdc5c961aeee54c09a



More information about the CRIU mailing list