[CRIU] [PATCH 9/9] Makefiles: protect from % rules, don't rebuild

Dmitry Safonov 0x7f454c46 at gmail.com
Mon Feb 27 01:34:19 PST 2017


2017-02-23 2:15 GMT+03:00 Kir Kolyshkin <kir at openvz.org>:
> GNU make tries to rebuild any makefiles it uses. While in general it's
> a good idea (and it is used e.g. in autoconf-based builds), in our case
> it is not necessary, as all the makefiles are static.
>
> More to say, as we have a few "match anything" rules for subdirectories,
> Makefiles in these subdirs are also matching these rules, which leads to
> excessive (re)building while a particular makefile is needed.
>
> Protect such Makefiles with explicit (or pattern) rules, so make knows
> it should do nothing to rebuild those.
>
> Signed-off-by: Kir Kolyshkin <kir at openvz.org>

I guess, it should fix also #285, does it?
If so, maybe it makes sense for Andrey to apply it with 'fixes' tag.

Reviewed-by: Dmitry Safonov <dsafonov at virtuozzo.com>

-- 
             Dmitry


More information about the CRIU mailing list