[CRIU] [PATCH 2/2] nmk/script: rm bad code

Kir Kolyshkin kir at openvz.org
Tue Sep 20 11:51:00 PDT 2016


On 09/20/2016 01:21 AM, Cyrill Gorcunov wrote:
> On Mon, Sep 19, 2016 at 01:58:02PM -0700, Kir Kolyshkin wrote:
>> I discovered that the scripts/ suffix is added to __nmk_dir despite
>> the fact it already contains it, ending in obviously wrong filenames
>> like scripts/nmk/scripts/scripts/msg.mk. As those files are non-existent,
>> make tried to recreate every .mk file, spawninga child to execute 'true'
>> command, like this (part of "make -dr" output):
>>
>>   
>>   #
>>   # Footer.
>> -$(__nmk_dir)scripts/build.mk:
>> -	@true
>>   ____nmk_defined__build = y
>>   endif
> I don't get why you've dropped off the footers?

As I said in changelog, two reasons:
1. They hijack the default target.
2. I see no reason for these.

Maybe you can explain #2 to me. I mean, what's the purpose of the below 
statement, what exactly it does?
> $(__nmk_dir)build.mk:
> 	@true


More information about the CRIU mailing list