[CRIU] [PATCH 2/2] nmk/script: rm bad code

Cyrill Gorcunov gorcunov at gmail.com
Tue Sep 20 01:21:37 PDT 2016


On Mon, Sep 19, 2016 at 01:58:02PM -0700, Kir Kolyshkin wrote:
> I discovered that the scripts/ suffix is added to __nmk_dir despite
> the fact it already contains it, ending in obviously wrong filenames
> like scripts/nmk/scripts/scripts/msg.mk. As those files are non-existent,
> make tried to recreate every .mk file, spawninga child to execute 'true'
> command, like this (part of "make -dr" output):
> 
>  
>  #
>  # Footer.
> -$(__nmk_dir)scripts/build.mk:
> -	@true
>  ____nmk_defined__build = y
>  endif

I don't get why you've dropped off the footers? Should not it be simply

$(__nmk_dir)build.mk:
	@true
____nmk_defined__build = y


More information about the CRIU mailing list