[CRIU] [PATCH 1/2] tty: Add missing break statement

[Cyrill Gorcunov]

On Wed, May 11, 2016 at 06:37:26PM +0300, Dmitry Safonov wrote:
> On 05/11/2016 06:22 PM, Cyrill Gorcunov wrote:
> > > 
> > > Maybe break under `if (minor == 0)`?
> > > I mean, other minors are for /dev/ttyS*, which seems to quite fit into
> > > serial console driver handeling (if I don't miss something).
> > 
> > No no. For tty-major we either should understand the driver
> > we're handling, in the code above it's VT driver, so if minor
> > is pointing somewhere else -- it's unknown tty.
> 
> Hmm, I'm not sure I got it -- for major 4:
>   0 = /dev/tty0		Current virtual console
>   1 = /dev/tty1		First virtual console
>   ...
>   63 = /dev/tty63	63rd virtual console
>   64 = /dev/ttyS0	First UART serial port
>   ...
>   255 = /dev/ttyS191	192nd UART serial port
> So, the rest seems to be ttyS* serial ports.

Then it's an error -- we should provide VT driver
for VT terminals only :/

Moreover UART serieal devices (at least for hardware
parts I've been working with) require a way more than
just plain open() over them to make them work properly
after restore.