[CRIU] [PATCH 1/2] tty: Add missing break statement

[Dmitry Safonov]

On 05/11/2016 06:22 PM, Cyrill Gorcunov wrote:
>>
>> Maybe break under `if (minor == 0)`?
>> I mean, other minors are for /dev/ttyS*, which seems to quite fit into
>> serial console driver handeling (if I don't miss something).
>
> No no. For tty-major we either should understand the driver
> we're handling, in the code above it's VT driver, so if minor
> is pointing somewhere else -- it's unknown tty.

Hmm, I'm not sure I got it -- for major 4:
   0 = /dev/tty0		Current virtual console
   1 = /dev/tty1		First virtual console
   ...
   63 = /dev/tty63	63rd virtual console
   64 = /dev/ttyS0	First UART serial port
   ...
   255 = /dev/ttyS191	192nd UART serial port
So, the rest seems to be ttyS* serial ports.

> Dima, while you're here. why your serial_driver doesn't
> provide driver::index field? The ext-tty doesnt provide
> as well but I think it's a mistake.
Yes, I thought to make index for it, but as I saw ext-tty,
I thought it's not compulsory. Looking here again, I think
it's a mistake.