[CRIU] [PATCH v5 3/5] Try to include userfaultfd with criu (part 1)

[Adrian Reber]

On Thu, Mar 17, 2016 at 03:56:52PM +0300, Pavel Emelyanov wrote:
> >> In particular, the call to collect_remaps_and_regfiles() should not be
> >> here as it picks up info about files, not memory.
> > 
> > Not knowing the complete details it seems it is necessary as mm.img
> > in my case contains exe_file_id: 2, which can be resolved with the
> > information from reg-files.img pointing to the actual binary. Now,
> > thinking about it, it seems irrelevant for lazy pages to know which
> > page belongs to which binary. I might be getting to the point where I
> > understand what you want. I will continue to get this resolved.
> 
> Great!
> 
> Don't hesitate asking more question if you have, all these interdependencies
> between images and objects are really tricky.

I am down to this:

        check_img_inventory();
        /* Allocate memory for task_entries */
        prepare_task_entries();
        prepare_pstree();
        struct rst_info *ri = rsti(root_item);

prepare_task_entries() seems to allocate the necessary memory structures
for prepare_pstree(). Without prepare_task_entries() prepare_pstree()
just segfaults as the pointers prepare_task_entries() is using are
partially still NULL. Would this be acceptable? Maybe it is easier if I
send the complete patch for review.

		Adrian