[CRIU] [PATCH v5 3/5] Try to include userfaultfd with criu (part 1)

Adrian Reber adrian at lisas.de
Thu Mar 17 06:28:09 PDT 2016


On Thu, Mar 17, 2016 at 03:56:52PM +0300, Pavel Emelyanov wrote:
> >>> It would probably help me to understand the situation if I knew why this
> >>> common code should not be used. 
> >>
> >> Common code can and should be used, but only the one that's really required.
> >>
> >> In particular, the call to collect_remaps_and_regfiles() should not be
> >> here as it picks up info about files, not memory.
> > 
> > Not knowing the complete details it seems it is necessary as mm.img
> > in my case contains exe_file_id: 2, which can be resolved with the
> > information from reg-files.img pointing to the actual binary. Now,
> > thinking about it, it seems irrelevant for lazy pages to know which
> > page belongs to which binary. I might be getting to the point where I
> > understand what you want. I will continue to get this resolved.
> 
> Great!
> 
> Don't hesitate asking more question if you have, all these interdependencies
> between images and objects are really tricky.

Sure, I will.

> > About my existing patches. Will you merge the way they are now, or will
> > you be waiting for further changes (like the ones discussed in this
> > thread).
> 
> I plan to merge them in criu-dev and then wait for the following stuff in
> the first place:

Perfect!

> 1. Relaxing the lazy daemon init, so that it only initializes the needed
>    subsystems

Working on it.

> 2. Passing pid-s via unix socket together with the uffd

That's already in the latest patchset I sent.

		Adrian


More information about the CRIU mailing list