[CRIU] [PATCH 10/10] tests: fix cgroupns test to not use nested namespaces

Tycho Andersen tycho.andersen at canonical.com
Thu Mar 3 06:45:38 PST 2016


On Thu, Mar 03, 2016 at 02:02:30PM +0300, Pavel Emelyanov wrote:
> OK, applied, but one comment
> 
> > diff --git a/test/zdtm/static/cgroupns.desc b/test/zdtm/static/cgroupns.desc
> > index 65748f5..88a9100 100644
> > --- a/test/zdtm/static/cgroupns.desc
> > +++ b/test/zdtm/static/cgroupns.desc
> > @@ -1 +1 @@
> > -{'flavor': 'h ns', 'flags': 'suid', 'feature': 'cgroupns', 'opts': '--manage-cgroups'}
> > +{'flavor': 'h', 'flags': 'suid', 'feature': 'cgroupns', 'opts': '--manage-cgroups'}
> 
> This creates an exceptional treatment for cgroup ns. Right now we have
> all the tests run without namespaces (h flavor), in all but user namespaces
> (ns flavor) and in all namespaces. This patch brings separate testing for
> cgns only (even w/o the usernamespace support).
> 
> I'd consider including cgns into the ns flavor.

Yes, I think this makes sense. I'll look into a patch for this as
well.

Tycho


More information about the CRIU mailing list