[CRIU] [PATCH 10/10] tests: fix cgroupns test to not use nested namespaces

Pavel Emelyanov xemul at virtuozzo.com
Thu Mar 3 03:02:30 PST 2016


OK, applied, but one comment

> diff --git a/test/zdtm/static/cgroupns.desc b/test/zdtm/static/cgroupns.desc
> index 65748f5..88a9100 100644
> --- a/test/zdtm/static/cgroupns.desc
> +++ b/test/zdtm/static/cgroupns.desc
> @@ -1 +1 @@
> -{'flavor': 'h ns', 'flags': 'suid', 'feature': 'cgroupns', 'opts': '--manage-cgroups'}
> +{'flavor': 'h', 'flags': 'suid', 'feature': 'cgroupns', 'opts': '--manage-cgroups'}

This creates an exceptional treatment for cgroup ns. Right now we have
all the tests run without namespaces (h flavor), in all but user namespaces
(ns flavor) and in all namespaces. This patch brings separate testing for
cgns only (even w/o the usernamespace support).

I'd consider including cgns into the ns flavor.

-- Pavel



More information about the CRIU mailing list