[CRIU] [PATCH v3] restore: Fetch mmap_minimal_address runtime

[Pavel Emelyanov]

On 12/08/2016 04:28 PM, Cyrill Gorcunov wrote:
> On Thu, Dec 08, 2016 at 04:25:48PM +0300, Pavel Emelyanov wrote:
>>> +
>>> +	if (value < default_mmap_min_addr) {
>>> +		pr_debug("Adjust mmap_min_addr %#lx -> %#lx\n",
>>> +			 value, default_mmap_min_addr);
>>
>> This doesn't build on ARM.
>>
>> In file included from criu/kerndat.c:16:0:
>> criu/kerndat.c: In function 'kerndat_get_mmap_min_addr':
>> criu/kerndat.c:136:12: error: format '%lx' expects argument of type 'long unsigned int', but argument 3 has type 'uint64_t {aka long long unsigned int}' [-Werror=format=]
>>    pr_debug("Adjust mmap_min_addr %#lx -> %#lx\n",
>>             ^
>> /criu/criu/include/log.h:68:21: note: in definition of macro 'pr_debug'
>>           LOG_PREFIX fmt, ##__VA_ARGS__)
>>                      ^~~
>>   CC       criu/log.o
> 
> Could you please just merge in explicit (unsigned long) conversion?
> 
> 	pr_debug("Adjust mmap_min_addr %#lx -> %#lx\n",
> 		(unsigned long)value, default_mmap_min_addr);
> .
> 

It's not just this place, I suppose...

-- Pavel