[CRIU] [PATCH v3] restore: Fetch mmap_minimal_address runtime

Pavel Tikhomirov snorcht at gmail.com
Mon Dec 19 01:37:35 PST 2016


Thanks! These patch fixes
https://ci.openvz.org/job/CRIU/job/CRIU-virtuozzo/job/criu-dev/1174/console


Best Regards, Tikhomirov Pavel.

2016-12-08 16:28 GMT+03:00 Cyrill Gorcunov <gorcunov at gmail.com>:

> On Thu, Dec 08, 2016 at 04:25:48PM +0300, Pavel Emelyanov wrote:
> > > +
> > > +   if (value < default_mmap_min_addr) {
> > > +           pr_debug("Adjust mmap_min_addr %#lx -> %#lx\n",
> > > +                    value, default_mmap_min_addr);
> >
> > This doesn't build on ARM.
> >
> > In file included from criu/kerndat.c:16:0:
> > criu/kerndat.c: In function 'kerndat_get_mmap_min_addr':
> > criu/kerndat.c:136:12: error: format '%lx' expects argument of type
> 'long unsigned int', but argument 3 has type 'uint64_t {aka long long
> unsigned int}' [-Werror=format=]
> >    pr_debug("Adjust mmap_min_addr %#lx -> %#lx\n",
> >             ^
> > /criu/criu/include/log.h:68:21: note: in definition of macro 'pr_debug'
> >           LOG_PREFIX fmt, ##__VA_ARGS__)
> >                      ^~~
> >   CC       criu/log.o
>
> Could you please just merge in explicit (unsigned long) conversion?
>
>         pr_debug("Adjust mmap_min_addr %#lx -> %#lx\n",
>                 (unsigned long)value, default_mmap_min_addr);
> _______________________________________________
> CRIU mailing list
> CRIU at openvz.org
> https://lists.openvz.org/mailman/listinfo/criu
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openvz.org/pipermail/criu/attachments/20161219/44a02882/attachment.html>


More information about the CRIU mailing list