[CRIU] [PATCH] Move headers around to fix issues on custom-built glibc

[Nikolay Borisov]

On Tue, Aug 16, 2016 at 9:15 PM, Dmitry Safonov <dsafonov at virtuozzo.com> wrote:
> On 08/16/2016 09:12 PM, Nikolay Borisov wrote:
>>
>>
>> You are correct about proliferation of the include order. However,
>> what I meant was that your fix doesn't eliminate the order dependency.
>> Maybe the proper way to fix this is add a 'configure' step which will
>> check what is defined and what not and based on that set some defines
>> in turn so that when criu is compiled it will now whether to include
>> its own definitions. But that would be significantly more work than
>> this simple fix here.
>
>
> I'm not sure, that you got my point -- I suggest to include system <fcntl.h>
> header only in CRIU's "fcntl.h", while inside CRIU use only
> "fcntl.h", which will have ifdefs after the system header inclusion
> (as it has right now).

Right, it wasn't clear from your initial email. I agree that will work
and at least limits the scope of the ordering to a single file.

>
> --
>              Dmitry