[CRIU] [PATCH] Move headers around to fix issues on custom-built glibc

Dmitry Safonov dsafonov at virtuozzo.com
Tue Aug 16 11:15:22 PDT 2016


On 08/16/2016 09:12 PM, Nikolay Borisov wrote:
>
> You are correct about proliferation of the include order. However,
> what I meant was that your fix doesn't eliminate the order dependency.
> Maybe the proper way to fix this is add a 'configure' step which will
> check what is defined and what not and based on that set some defines
> in turn so that when criu is compiled it will now whether to include
> its own definitions. But that would be significantly more work than
> this simple fix here.

I'm not sure, that you got my point -- I suggest to include system 
<fcntl.h> header only in CRIU's "fcntl.h", while inside CRIU use only
"fcntl.h", which will have ifdefs after the system header inclusion
(as it has right now).

-- 
              Dmitry


More information about the CRIU mailing list