[CRIU] [PATCH] criu: add a shell wrapper

Dmitry Safonov dsafonov at virtuozzo.com
Thu Apr 21 02:29:11 PDT 2016


On 04/21/2016 10:13 AM, Adrian Reber wrote:
> On Wed, Apr 20, 2016 at 05:49:02PM +0300, Dmitry Safonov wrote:
>> I may suggest - can we use ld's -rpath option?
>> That will add directory to runtime library search path.
>> I mean, something like that (completely untested):
>>
>> --->8---
>> diff --git a/criu/Makefile b/criu/Makefile
>> index 1836bde5e1d3..14bf6d3c08f6 100644
>> --- a/criu/Makefile
>> +++ b/criu/Makefile
>> @@ -1,6 +1,7 @@
>>   # here is a workaround for a bug in libnl-3:
>>   # 6a8d90f5fec4 "attr: Allow attribute type 0"
>>   LDFLAGS                        += -Wl,--wrap=nla_parse,--wrap=nlmsg_parse
>> +LDFLAGS                        += -Wl,-rpath,'$$ORIGIN/../soccr'
> This sounds like a bad idea from the packaging stand point of view.
> For the criu binary installed under /usr this will be the wrong path.

Hmm, so what's the point?
It can contain multiple paths:
LDFLAGS                        += 
-Wl,-rpath,'/lib:/usr/lib:$$ORIGIN/../soccr'

Or anything else.
Or I didn't get your message right.

-- 
Regards,
Dmitry Safonov



More information about the CRIU mailing list