[CRIU] [PATCH 1/4] log: Don't modify global @errno in __print_on_level
Cyrill Gorcunov
gorcunov at gmail.com
Fri Mar 27 04:13:02 PDT 2015
On Fri, Mar 27, 2015 at 02:07:25PM +0300, Pavel Emelyanov wrote:
> On 03/26/2015 11:46 AM, Andrew Vagin wrote:
> > Acked-by: Andrew Vagin <avagin at parallels.com>
> >
> > On Thu, Mar 26, 2015 at 11:23:12AM +0300, Cyrill Gorcunov wrote:
> >> The __print_on_level routine may modify global @errno
> >> variable which is inacceptable: this is logging routine
> >> which must be transparent to the rest of the program code.
> >>
> >> Thus save @errno in local @__errno variable and restore
> >> it on return.
> >>
> >> Signed-off-by: Cyrill Gorcunov <gorcunov at openvz.org>
>
> Applied, thanks. Can you grep the sources for places where we
> handled errno manually to workaround this. I remember we did
> it in a couple of places, but don't remember exactly where they
> are.
Sure, will do.
More information about the CRIU
mailing list