[CRIU] [PATCH 1/4] log: Don't modify global @errno in __print_on_level

Pavel Emelyanov xemul at parallels.com
Fri Mar 27 04:07:25 PDT 2015


On 03/26/2015 11:46 AM, Andrew Vagin wrote:
> Acked-by: Andrew Vagin <avagin at parallels.com>
> 
> On Thu, Mar 26, 2015 at 11:23:12AM +0300, Cyrill Gorcunov wrote:
>> The __print_on_level routine may modify global @errno
>> variable which is inacceptable: this is logging routine
>> which must be transparent to the rest of the program code.
>>
>> Thus save @errno in local @__errno variable and restore
>> it on return.
>>
>> Signed-off-by: Cyrill Gorcunov <gorcunov at openvz.org>

Applied, thanks. Can you grep the sources for places where we
handled errno manually to workaround this. I remember we did
it in a couple of places, but don't remember exactly where they
are.



More information about the CRIU mailing list