[CRIU] [PATCH] make: protobuf -- Rework build procedure

Cyrill Gorcunov gorcunov at gmail.com
Wed Jan 21 08:28:14 PST 2015


On Wed, Jan 21, 2015 at 08:12:18AM -0800, Filipe Brandenburger wrote:
> Hi,
> 
> On Wed, Jan 21, 2015 at 4:04 AM, Cyrill Gorcunov <gorcunov at gmail.com> wrote:
> > no problem, this makefile has to be cleaned up anyway.
> 
> As long as recursive makefiles are being used, it's unlikely that all
> build problems will be fixed and that -j will reliably work... I have
> always had problems with -j in criu build (so I solved it by not using
> -j).
> May I suggest using non-recursive makefiles instead?
> 
> I would volunteer to move criu towards a "./configure; make; make
> install" style of build using automake, autoconf and libtool, with a
> non-recursive Makefile.am. That would make parallel build with -j work
> reliably, make Makefile.config more reliable, get rid of
> scripts/Makefile.*, make out-of-tree builds work, etc. Would that be
> something that interests you? In other words, if I do the work, would
> you accept the contribution? Or do you have reasons to keep the
> current build system (even if sometimes it's a pain to maintain to
> support things like -j)?

Well, I personally would like to escape using automake and friends,
but on the other hands there might be more experts in automake
than plain make and this would bring more people to support
building procedure. So that I leave it to the rest of the dev
crew (while I personally prefer plain make, I can happily live
with any approach ;)

Guys, lets vote? Pavel, Andrew, Ruslan?


More information about the CRIU mailing list