[CRIU] [PATCH] make: protobuf -- Rework build procedure

Filipe Brandenburger filbranden at google.com
Wed Jan 21 08:12:18 PST 2015


Hi,

On Wed, Jan 21, 2015 at 4:04 AM, Cyrill Gorcunov <gorcunov at gmail.com> wrote:
> no problem, this makefile has to be cleaned up anyway.

As long as recursive makefiles are being used, it's unlikely that all
build problems will be fixed and that -j will reliably work... I have
always had problems with -j in criu build (so I solved it by not using
-j).

May I suggest using non-recursive makefiles instead?

I would volunteer to move criu towards a "./configure; make; make
install" style of build using automake, autoconf and libtool, with a
non-recursive Makefile.am. That would make parallel build with -j work
reliably, make Makefile.config more reliable, get rid of
scripts/Makefile.*, make out-of-tree builds work, etc. Would that be
something that interests you? In other words, if I do the work, would
you accept the contribution? Or do you have reasons to keep the
current build system (even if sometimes it's a pain to maintain to
support things like -j)?

Cheers,
Filipe


More information about the CRIU mailing list