[CRIU] [PATCH 0/3] crit core-dump feature

[Ruslan Kuprieiev]

On 27.04.15 21:10, Cyrill Gorcunov wrote:
> On Mon, Apr 27, 2015 at 03:05:10PM +0300, Pavel Emelyanov wrote:
>> Cyrill, please, review the patches.
>>
> While I'm fine with python part, I don't like how we handle
> task's command line: in kernel it's NOT limited to 80 symbols
> thus one needs to either define
>
> #define ELF_PRARGSZ (80) /* Number of chars for args */
>
> or use predefined constant (I didn't check if it lives in
> standart header). 80 bytes is a max allowed in core but
> we should save the complete command line in image file
> I think (which implies that parse_pid_cmdline should
> take accumulator size as well). The kernel itself may
> provide up to 4K arguments iirc.
>
> 	Cyrill

Hi Cyrill,

Yes, I am aware of kernel not limiting cmdline length to 80 symbols, but
since this data is only needed by a core dump, I've decided that
there is no reason to bring more than we need, especially considering
that extending to a full cmdline length could be accomplished with an
ease if there will be a request for it.

Should we bring full cmdline contents anyway?

Ruslan